Code Review

Review Steps

Here is a step by step description of API review process.


These are the roles that different people play in reviews:


  • Submitter: the person proposing API change and asking for review
Submitter's task is to prepare information for review, properly announce it, drive the review procedure, answer questions during review via mail/mantis and in the face to face review, and record the result of the review

  • Reviewers: people assigned or choosen by the reviewer to do the review
Reviewers need to study the issue and provide feedback and final decision in a timely fashion, they need to participate in face to face meetings for the reviews they are responsible to verify that the result of the document is correctly recorded in the summary document and/or Mantis issue tracker.

Code Review Checklist

Function

Style

Architecture

Exception handling