View Issue Details

IDProjectCategoryView StatusLast Update
0000250WackoWikiactionpublic2009-10-13 16:03
Reporterpascalvmf Assigned Topascalvmf  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.2 
Target Version5.0.betaFixed in Version5.0.beta 
Summary0000250: linkstree.php incorrect use of $this (fix included)
Descriptionactions/linkstree.php in version R4.3rc

there is a typo in the script $this should be replaced by $wacko in the function body

Fix folllows in diff -u format :

diff -u linkstree.php.old linkstree.php
--- linkstree.php.old 2009-01-05 19:08:17.000000000 +0100
+++ linkstree.php 2009-01-05 19:08:23.000000000 +0100
@@ -10,7 +10,7 @@
                        if ($indent)
                        print((str_repeat(" ",$indent*7)).$wacko->Link("/".$node, "", $node)."
\n");

- $pages = $wacko->LoadAll("select to_tag from ".$wacko->config["table_prefix"]."links, ".$wacko->config["table_prefix"]."pages where from_tag='".quote($this->dblink, $node)."' AND ".$wacko->config["table_prefix"]."links.to_tag = ".$wacko->config["table_prefix"]."pages.tag order by to_tag asc");
+ $pages = $wacko->LoadAll("select to_tag from ".$wacko->config["table_prefix"]."links, ".$wacko->config["table_prefix"]."pages where from_tag='".quote($wacko->dblink, $node)."' AND ".$wacko->config["table_prefix"]."links.to_tag = ".$wacko->config["table_prefix"]."pages.tag order by to_tag asc");

                        if (is_array($pages))
                        {
Steps To Reproducehttp://test.wackowiki.org/Bugs/250
Additional Informationsymptom with this bug activated is php error message :


Links tree

Fatal error: Using $this when not in object context in <webroot_path>/wacko.r4.3rc/actions/linkstree.php on line 13
TagsNo tags attached.

Activities

administrator

2009-01-05 21:28

administrator   ~0000549

Fixed the link construction for root page to work on a subpage -> ((/RootName RootName)) too

Fix SVNed with revision 215

administrator

2009-01-05 21:41

administrator   ~0000550

Last edited: 2009-02-13 12:33

but we don't have a GetConfigValue("navigation_links") mhhm....
this is the old wakka value for the bookmarks which were replaced log time ago with default_bookmarks and site_bookmarks

replaced navigation_links with default_bookmarks but it won't work when we use
((SeitenIndex Index)) for instance
SVNed recent changes with revision 257, but more changes needed

Issue History

Date Modified Username Field Change
2009-01-05 18:23 pascalvmf New Issue
2009-01-05 18:23 pascalvmf Legacy => NEW
2009-01-05 19:16 administrator Status new => acknowledged
2009-01-05 19:16 administrator Description Updated
2009-01-05 19:41 administrator Status acknowledged => confirmed
2009-01-05 19:41 administrator Steps to Reproduce Updated
2009-01-05 19:49 administrator Product Version => 4.2
2009-01-05 19:49 administrator Target Version => 5.0.0
2009-01-05 21:28 administrator Note Added: 0000549
2009-01-05 21:28 administrator Assigned To => pascalvmf
2009-01-05 21:28 administrator Status confirmed => resolved
2009-01-05 21:28 administrator Resolution open => fixed
2009-01-05 21:28 administrator Fixed in Version => 5.0.0
2009-01-05 21:31 administrator Build => r4.3rc
2009-01-05 21:31 administrator Summary r4.3rc linkstree.php incorrect use of $this (fix included) => linkstree.php incorrect use of $this (fix included)
2009-01-05 21:41 administrator Note Added: 0000550
2009-02-13 12:04 administrator Note Edited: 0000550
2009-02-13 12:06 administrator Note Edited: 0000550
2009-02-13 12:33 administrator Note Edited: 0000550
2009-10-13 16:00 administrator Target Version 5.0.0 => 5.0.beta
2009-10-13 16:03 administrator Fixed in Version 5.0.0 => 5.0.beta
2010-03-08 10:09 administrator Category Action => action