WackoWiki

View source for Re: Backup & restore

Yes, I checked this today on a Windows instance.

%%(hl diff)
diff --git a/src/admin/module/db_restore.php b/src/admin/module/db_restore.php
index 00a81ff..b5c992e 100644
--- a/src/admin/module/db_restore.php
+++ b/src/admin/module/db_restore.php
@@ -402,7 +402,7 @@
 			<?php echo $engine->_t('RestoreInfo'); ?>
 		</p>
 <?php
-		if (!is_executable($dir))
+		if (!(PHP_OS_FAMILY === 'Windows') && !is_executable($dir))
 		{
 			echo substr(sprintf('%o', fileperms($dir)), -4) . "<br>\n";
 			echo output_image($engine, false) .
%%

It seems ##is_executable()## checks if the archives can be unpacked, which works only on Unix. This is the only call of this function in the code base. I think the check can be skiped for Windows. Did I miss something? 

The patch is now in the repository for the master and 6.0 branch.

Thanks for reporting.