View Issue Details

IDProjectCategoryView StatusLast Update
0000147WackoWikiregular expressionspublic2009-08-19 09:39
ReporterFreeman Assigned ToTann San  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version4.2 
Target Version4.3.rcFixed in Version4.3.rc 
Summary0000147: fixed handling of links contain hyphen and dot characters
Descriptionfixed handling of links contain hyphen and dot characters
TagsNo tags attached.
Attached Files
wakka_names_hyphen_and_dot_fix.diff (1,042 bytes)   
--- a/classes/wacko.php	2005-08-26 23:03:19.000000000 +0400
+++ b/classes/wacko.php	2006-04-03 14:59:05.218261335 +0400
@@ -2109,7 +2110,7 @@ class Wacko
     $tag = $this->tryUtfDecode($tag);
 //    if (!$_REQUEST["add"]=="1" || $this->method=="watch" ) 
    $tag = str_replace("'", "_", str_replace("\\", "", str_replace("_", "", $tag)));
-   $tag = preg_replace("/[^".$this->language["ALPHANUM_P"]."\_\-]/", "", $tag);
+   $tag = preg_replace("/[^".$this->language["ALPHANUM_P"]."\_\-\.]/", "", $tag);
 
    //$this->tag=$this->Translit($tag, 1);
    $this->tag = $tag;
--- a/handlers/page/rename.php	2006-04-03 14:10:33.425072246 +0400
+++ b/handlers/page/rename.php	2006-04-03 14:10:30.749887914 +0400
@@ -25,7 +25,7 @@
      
      $supernewname = $this->NpjTranslit($NewName);
 
-     if (!preg_match("/^(".$this->language["ALPHANUM"]."+)$/", $NewName))
+     if (!preg_match("/^([\_\.\-".$this->language["ALPHANUM_P"]."]+)$/", $NewName))
      {
        print($this->GetResourceValue("BadName")."<br />\n");
      } 

Activities

Tann San

2008-04-18 14:50

manager   ~0000317

Merged in Freemans diff file, thank you Freeman :¬)

Issue History

Date Modified Username Field Change
2008-01-10 11:38 administrator New Issue
2008-01-10 11:38 administrator Status new => assigned
2008-01-10 11:38 administrator Assigned To => Tann San
2008-01-10 11:38 administrator File Added: wakka_names_hyphen_and_dot_fix.diff
2008-01-10 11:38 administrator Legacy => NEW
2008-01-10 11:39 administrator Reporter administrator => Freeman
2008-01-10 11:41 administrator Target Version => 5.0.0
2008-04-18 14:50 Tann San Status assigned => resolved
2008-04-18 14:50 Tann San Fixed in Version => 5.0.0
2008-04-18 14:50 Tann San Resolution open => fixed
2008-04-18 14:50 Tann San Note Added: 0000317
2009-08-19 09:22 administrator Fixed in Version 5.0.0 => 4.3.rc
2009-08-19 09:39 administrator Target Version 5.0.0 => 4.3.rc
2010-03-08 10:20 administrator Category Regular Expressions => regular expressions