View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000019 | WackoWiki | appearance | public | 2007-08-28 00:25 | 2009-08-19 09:39 |
| Reporter | EoNy | Assigned To | administrator | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 4.2 | ||||
| Target Version | 4.3.rc | Fixed in Version | 4.3.rc | ||
| Summary | 0000019: hard-coded condition for "tabs" theme in handlers | ||||
| Description | In "edit.php" handler there's a hardcoded condition to return a different code for textarea for the "tabs" theme. | ||||
| Additional Information | Code in question handlers/page/edit.php Line 132: if ($this->GetConfigValue("theme")=="tabs") $output .= "<textarea id=\"postText\" name=\"body\" rows=\"40\" cols=\"60\" class=\"TextArea\">"; else $output .= "<textarea id=\"postText\" name=\"body\" rows=\"40\" cols=\"60\" style=\"width: 100%; height: 400px\" class=\"TextArea\">"; Why it's a nuisance: 1) making theme-dependent code seems to be incorrect, especially when it resolves the problem that can be resolved in the stylesheet. 2) second version (which is used for all the other themes but "tabs") is much worse as it returns a code with the fixed size of textarea, and that overrides stylesheet and causes problems when the pages are rendered. To fix it a person has to modify the handler, and then remember to modify it again after the update. | ||||
| Tags | No tags attached. | ||||
| related to | 0000100 | resolved | administrator | localize search box in Tabs theme |
| related to | 0000280 | resolved | administrator | remove edit_table_based from edit handler |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-08-28 00:25 | EoNy | New Issue | |
| 2007-08-29 05:58 | administrator | Legacy | => NPJ |
| 2007-10-13 01:58 | administrator | Relationship added | related to 0000100 |
| 2007-11-01 14:00 | administrator | Assigned To | => administrator |
| 2007-11-01 14:00 | administrator | Status | new => assigned |
| 2007-11-01 14:00 | administrator | Target Version | => 5.0.0 |
| 2007-12-02 16:24 | administrator | Additional Information Updated | |
| 2007-12-02 17:48 | administrator | Note Added: 0000230 | |
| 2007-12-02 17:48 | administrator | Resolution | open => fixed |
| 2007-12-02 17:48 | administrator | Fixed in Version | => 5.0.0 |
| 2007-12-02 17:50 | administrator | Status | assigned => resolved |
| 2007-12-04 14:25 | administrator | Note Edited: 0000230 | |
| 2009-03-08 17:12 | administrator | Relationship added | related to 0000280 |
| 2009-08-19 09:22 | administrator | Fixed in Version | 5.0.0 => 4.3.rc |
| 2009-08-19 09:39 | administrator | Target Version | 5.0.0 => 4.3.rc |
| 2010-03-08 10:10 | administrator | Category | Appearance => appearance |
