View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000085 | WackoWiki | handler | public | 2007-09-19 23:39 | 2009-08-19 09:39 |
| Reporter | administrator | Assigned To | Tann San | ||
| Priority | high | Severity | block | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 4.2 | ||||
| Target Version | 4.3.rc | Fixed in Version | 4.3.rc | ||
| Summary | 0000085: Renaming of pages should also affect /files/perpage | ||||
| Description | files uploaded to an certain page (/files/perpage, not global uploaded files) should also be renamed, yet only references in upload table where updated result: inaccessible files (e.g. @oldname@picture.png should become @newname@piture.png in /files/perpage). | ||||
| Additional Information | /files/perpage * @wikiadmin@picture.png * @tasks@project@desciption.pdf * @checklists@house@energy@heating.xls | ||||
| Tags | No tags attached. | ||||
|
|
Added RenameFiles function to classes/wacko.php and called it from /handlers/pages/rename.php and /handlers/pages/massrename.php. |
|
|
I goofed up. Received this bug report: try to rename a page with local attachment to test/test/test/test/test/yourpage my result @test@test@test@test@vendeeglobe@st@test@vendeeglobe@st@test@vendeeglobe@st@test@vendeeglobe@st@test@vendeeglobe@st@test@vendeeglobe@st@test@vendeeglobe@st@test@vendeeglobe@st@test@vendeeglobe@st@test@vendeeglobe@st@test@vendeeglobe@01macarthur_gr.jpg expected result @test@test@test@test@vendeeglobe@01macarthur_gr.jpg |
|
|
if you rename the page one by one first /test/yourpage second /test/test/yourpage third /test/test/test/yourpage and so on then the error seems not to appear |
|
|
I wouldn't worry about it for now. I have to (read as MUST) fix this before my current project goes out of the door so it is the top item on my todo list for Wacko right now :¬) I think I know exactly where the problem is. It's probably going to come down to a one liner that needs a bit of refactoring. |
|
|
phew! I totaly forgot about this bug and I'm due to hand over the project I implemented it in this week as well. Better get fixing it soon I guess :¬) |
|
|
I don't seem able to recreate this bug. I've created a new install on my local server using the latest SVN source. I created a page called FileRenameTest and then uploaded a file for just that page called screenshot.jpg. Then I renamed the page to /test/test/test/test/test/FileRenameTest and it renamed the file to @test@test@test@test@test@filerenametest@screenshot.jpg which is the expected result. I've played around with renaming the page in different ways and it always works for me. Can you detail a more specific way of reproducing the bug so I can narrow it down. |
|
|
will test it again, will post result here later |
|
|
1) if a child page has the same name as the page that is being renamed then it will also be renamed. files get renamed correctly. 2) renaming a single page will recursively rename all assocatied files for that cluster instead of just the files attached to that page. that behaviour should only happen for massrename handler. |
|
|
Seems to work for me, think my last note was not a bug but just a logic check. Tested out 3 levels of sub pages with file uploads. Some pages had same name as their parent. All seemed ok to me. Re-open this bug if it breaks for someone although I'll need very specific instructions on how to re-create the problem. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-09-19 23:39 | administrator | New Issue | |
| 2007-09-19 23:39 | administrator | Legacy | => NEW |
| 2007-09-19 23:41 | administrator | Status | new => acknowledged |
| 2007-09-19 23:41 | administrator | Target Version | => 5.0.0 |
| 2007-09-19 23:42 | administrator | Legacy | NEW => NPJ |
| 2007-09-20 12:09 | Tann San | Status | acknowledged => assigned |
| 2007-09-20 12:09 | Tann San | Assigned To | => Tann San |
| 2007-09-20 12:10 | Tann San | Status | assigned => resolved |
| 2007-09-20 12:10 | Tann San | Fixed in Version | => 5.0.0 |
| 2007-09-20 12:10 | Tann San | Resolution | open => fixed |
| 2007-09-20 12:10 | Tann San | Note Added: 0000092 | |
| 2007-09-25 09:25 | Tann San | Status | resolved => feedback |
| 2007-09-25 09:25 | Tann San | Resolution | fixed => reopened |
| 2007-09-25 09:25 | Tann San | Note Added: 0000106 | |
| 2007-09-25 11:49 | administrator | Note Added: 0000107 | |
| 2007-09-25 11:51 | Tann San | Note Added: 0000108 | |
| 2007-09-26 09:30 | Tann San | Severity | minor => block |
| 2007-09-26 09:30 | Tann San | Status | feedback => acknowledged |
| 2007-10-20 21:41 | Tann San | Note Added: 0000169 | |
| 2007-11-28 21:29 | Tann San | Note Added: 0000203 | |
| 2007-11-29 14:59 | administrator | Note Added: 0000213 | |
| 2008-01-02 12:49 | Tann San | Note Added: 0000277 | |
| 2008-06-09 09:55 | Tann San | Status | acknowledged => resolved |
| 2008-06-09 09:55 | Tann San | Resolution | reopened => fixed |
| 2008-06-09 09:55 | Tann San | Note Added: 0000356 | |
| 2009-08-19 09:22 | administrator | Fixed in Version | 5.0.0 => 4.3.rc |
| 2009-08-19 09:39 | administrator | Target Version | 5.0.0 => 4.3.rc |
| 2010-03-08 10:14 | administrator | Category | Handler => handler |
