View Issue Details

WikiJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000359WackoWikiapachepublic2010-04-10 17:162015-06-02 11:34
ReporterElar9000 Assigned ToElar9000  
PrioritynormalSeverityfeatureReproducibilityalways
Status closedResolutionnot fixable 
Product Version4.3.rc 
Summary0000359: Duplicate HomePage entry at /HomePage and at / (or redirect for main page)
DescriptionWhen the redirect from / to /HomePage was removed, to allow WackoWiki-website to have a root page (as most of Search Engines like the website to have), there was made a mistake. When we lost the redirect we got two identical pages / and /HomePage. (In the current version of HG the redirect is back but it's not much better than duplicate content).
Why we can't leave this:
1. Search Engines strongly dislike this - so this duplication of content or redirect would harm the indexation of the WackoWiki-website.
2. WackoUsers would like to link to / like they link to any other page ((/ Here is our main page)) - this won't work, cause the proper address is /HomePage and the link should be ((/HomePage Here is our main page)).
Steps To Reproduce1. Duplication / Redirect
Visit:
http://test.wackowiki.org/
http://test.wackowiki.org/HomePage
a) they're same or b) you were redirected from / to /HomePage - depends of version.

2. Try to create the link ((/ Here comes our homepage)) - you won't succeed.

http://wackowiki.sourceforge.net/test/Bugs/359
Additional InformationI offer to overcome this making some changes in classes/wacko.php:

    // returns the full url to a page/method.
    function Href($method = "", $tag = "", $params = "", $addpage = 0)
    {
        //To make ((/ Link to homepage)) work part 2 - show href="/" for "root_page"
        $page_address = $this->MiniHref($method, $tag, $addpage);
        if ($page_address == $this->config["root_page"]) $href = $this->config["base_url"];
        else $href = $this->config["base_url"].( $this->config["rewrite_mode"] ? "" : "?page=" ).$page_address;
   
        if ($addpage) $params = "add=1".($params ? "&".$params : "");
        if ($params) $href .= ($this->config["rewrite_mode"] ? "?" : "&").$params;

        return $href;
    }

in function Link add:

    // To make ((/ Link to homepage)) work part 1 - say "/" is "root_page"
        if ($tag=="/") $tag = "/".$this->config["root_page"];
     

 after:

    function Link($tag, $method = "", $text = "", $track = 1, $safe = 0, $linklang = "", $anchorlink = 1)
    {
        $class = '';
        $icon = '';
        $title = '';
        $lang = '';
        $url = '';
        $imlink = false;
        $text = str_replace('"', """, $text);



TagsNo tags attached.

Activities

administrator

2015-04-07 18:12

administrator   ~0000944

Last edited: 2015-04-07 19:13

 Can you rewrite the patch and submit it as .diff against our dev repo head, I can't see what it should do either way.


Atm. it just accepts both ways without redirect, right and it should redirect from Homepage to base_url. The recent behaviour was patched back from the openSpace fork.

link()
unwrap_link()
run()
syntax / ./

general behaviour (do we need settings, examples from other places - haha differs: WP redirect to Main_Page)

What option is preferred?
-> base_url

but remember as soon as you need a page handler you require the page_tag again
http://wackowiki.sourceforge.net/test/HomePage/properties
-> status quo

Issue History

Date Modified Username Field Change
2010-04-10 17:16 Elar9000 New Issue
2010-04-10 17:16 Elar9000 Status new => assigned
2010-04-10 17:16 Elar9000 Assigned To => Elar9000
2010-04-10 17:19 Elar9000 Description Updated
2010-04-10 17:19 Elar9000 Additional Information Updated
2010-05-14 23:00 administrator Priority urgent => normal
2010-05-14 23:00 administrator Target Version 5.0.beta => 5.0.0
2012-04-22 17:04 administrator Target Version 5.0.0 => 5.4.0
2014-03-21 14:57 administrator Target Version 5.4.0 => 5.5.0
2015-02-19 19:29 administrator Target Version 5.5.0 => 6.1.29
2015-04-07 18:12 administrator Note Added: 0000944
2015-04-07 18:13 administrator Target Version 6.1.29 => 5.5.0
2015-04-07 18:17 administrator Steps to Reproduce Updated
2015-04-07 18:44 administrator Note Edited: 0000944
2015-04-07 18:51 administrator Note Edited: 0000944
2015-04-07 18:54 administrator Note Edited: 0000944
2015-04-07 18:57 administrator Note Edited: 0000944
2015-04-07 19:03 administrator Note Edited: 0000944
2015-04-07 19:03 administrator Note Edited: 0000944
2015-04-07 19:07 administrator Note Edited: 0000944
2015-04-07 19:08 administrator Note Edited: 0000944
2015-04-07 19:12 administrator Note Edited: 0000944
2015-04-07 19:13 administrator Note Edited: 0000944
2015-06-02 11:34 administrator Status assigned => closed
2015-06-02 11:34 administrator Resolution open => not fixable
2015-06-02 11:34 administrator Target Version 5.5.0 =>