View Issue Details

IDProjectCategoryView StatusLast Update
0000444WackoWikiadministrationpublic2016-09-21 09:18
ReporterbirnbacsAssigned Toadministrator 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx86OSOpenBSDOS Version9.2-RELEASE-p4
Product Version5.4.0 
Target Version5.5.xFixed in Version5.5.rc2 
Summary0000444: AdminPanel -> Broken Groups management
DescriptionGroups administration fails. Forms are not properly not displayed. Database entries get changed wrongly.

Inspection of the code reveals that portions seem to be incorrectly recycled. For instance, the 'add member into group' reuses parts of 'add new group'. Soe logging messages are wrong (GroupsAdded after adding a member to a group).

Adding a member to a group failed as group_id is always 0 (table usergroup_member)

Steps To ReproduceOpen admin panel, select group management. Try to add/remove a user to/from a group.
Additional InformationRepairing the file admin/modules/groups.php is beyond my skills, the code seems to suffer gravely from copy-pasting. Repairing may be a minor job for the responsible person, though.
TagsNo tags attached.

Relationships

related to 0000117 resolvedadministrator GUI interface to define user groups 

Activities

birnbacs

2014-07-01 20:22

developer  

groups.php (22,870 bytes)

birnbacs

2014-07-01 20:30

developer  

wacko.de.php (61,676 bytes)

birnbacs

2014-07-01 20:32

developer   ~0000928

Fixed many issues, see enclosed file 'group.php'. However, some issues remain:

* file needs to be reviewed for QA
* is it sensible to allow a non-member of a group to become its moderator?
* members of a group should not be displayed in the 'add user' selector
* some $engine->set_message() get displayed not after an operation is complete but after the successive operation. Reproducible with 'add user' and 'add group'

I also changed some texts in wacko.de.php, see enclosed file.

Please note that the file that is part of the distribution is in a shameful condition and should never have shipped.

administrator

2014-07-03 20:13

administrator   ~0000929

Last edited: 2014-07-12 17:36

View 2 revisions

This is also true for other parts of the Admin panel and this is the reason why there is no documentation and it is still marked as Beta. But I merged and back ported it from the openSpace fork from pgpru.com - added some more proof of concept sections - and was more focused on get it to run. Guess so this is my mess.

administrator

2014-07-05 14:59

administrator   ~0000931

Committed a first update:
http://wackowiki.hg.sourceforge.net/hgweb/wackowiki/dev/rev/1586934a5e62

I still work on the other issues, its easy the correct success message display but this touches other unsolved questions like how we manage the localization and the log messages in the AP.

administrator

2014-07-12 11:23

administrator   ~0000932

Fixed message sets:
http://wackowiki.hg.sourceforge.net/hgweb/wackowiki/dev/rev/053ffcf6221c

Issue History

Date Modified Username Field Change
2014-06-26 08:00 birnbacs New Issue
2014-07-01 20:22 birnbacs File Added: groups.php
2014-07-01 20:30 birnbacs File Added: wacko.de.php
2014-07-01 20:32 birnbacs Note Added: 0000928
2014-07-03 20:13 administrator Note Added: 0000929
2014-07-03 20:13 administrator Assigned To => administrator
2014-07-03 20:13 administrator Status new => confirmed
2014-07-03 21:18 administrator Target Version => 5.6.x
2014-07-03 21:33 administrator Relationship added related to 0000117
2014-07-05 14:49 administrator Summary AdminPanel -> Groups management is a mess => AdminPanel -> Broken Groups management
2014-07-05 14:59 administrator Note Added: 0000931
2014-07-12 11:23 administrator Note Added: 0000932
2014-07-12 17:36 administrator Note Edited: 0000929 View Revisions
2015-02-19 19:19 administrator Target Version 5.6.x => 5.5.x
2015-02-22 18:13 administrator Status confirmed => resolved
2015-02-22 18:13 administrator Resolution open => fixed
2015-02-22 18:13 administrator Fixed in Version => 5.5.x
2016-09-21 09:18 administrator Fixed in Version 5.5.x => 5.5.rc2