View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000026 | WackoWiki | editing | public | 2007-08-28 22:48 | 2011-05-31 23:23 |
| Reporter | administrator | Assigned To | Tann San | ||
| Priority | normal | Severity | feature | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Product Version | 4.2 | ||||
| Target Version | 5.0.beta | Fixed in Version | 5.0.beta | ||
| Summary | 0000026: make comments capable for editing | ||||
| Description | make comments capable for editing, like in Mantis very often you post something too fast or you want add something later without deleting the original one (keep it in line, in the original place) | ||||
| Additional Information | RobertVaeth: ~/handlers/page/show.php: Add after line 209 (thats s.th. like print("<a href=\"".$this->href("remove",$comment["tag"]"...): print("<a href=\"".$this->href("edit",$comment["tag"])."\">Edit</a> "); ~/classes/wacko.php: Replace in line 1537 (there a comment called COMMENTS one line above) at the end the word time by supertag That's all, you should now be able to edit your own comments... | ||||
| Tags | No tags attached. | ||||
| related to | 0000328 | resolved | administrator | add Comment Title |
| child of | 0000352 | confirmed | Wacko-powered forum |
|
|
kukutz 15-11-2004 15:12 We have no plans to do that. Sorry. May be someone send some patch for us. RobertVaeth 07-01-2005 23:10 As far as I've seen it, you can re-edit an existing comment (just you due to the given permissions). If you hover over the delete-button, you'll see the name of the comment, e.g. Comment438. Now you could jump to the page that is named Comment438 and edit this page. The problem is, that the comments are sorted by date (the date is the date of the last edited version), so your comment will move to the end of the comments because of the date. I hope you have understood what I meant :-) But there's also a-way-around, to change the method of sorting, it's possible to sort the comments by "supertag" (thats the site name, e.g. comment438). So here's the hacking: ~/handlers/page/show.php: Add after line 209 (thats s.th. like print("<a href=\"".$this->href("remove",$comment["tag"]"...): print("<a href=\"".$this->href("edit",$comment["tag"])."\">Edit</a> "); ~/classes/wacko.php: Replace in line 1537 (there a comment called COMMENTS one line above) at the end the word time by supertag That's all, you should now be able to edit your own comments...but the date is changes also -- but that's your job ;-) Hope it helped, Robert Vaeth mb 18-02-2005 23:03 can you add the hack in R4.2? |
|
|
now the field 'created' is available |
|
|
Just added an edit button. The actual functionality was already there since comments are actually pages. |
|
|
This was revision 695. |
|
|
1) but then comments must be sorted with the crated field else it destroys the order of the comments, 2) additional now we have to consider that suddenly comments may have a record in revisions 3) and in editing the 'comment title' should shown for comments instead of 'change summary' and 'minor edit' |
|
|
pants. I wish you'd posted that earlier as initially this sounded like a simple task. Now I have to go back and check other things out. Seems it's broken anyhow. If you edit a comment and save it, it then becomes a proper page and no longer a comment. The "new" page is then an orphan. I'll make it sort by creation date i.e. your point (1). Your point (2) doesn't matter. It's fine having them show up in the changed pages list. It shouldn't be that hard to remove them from there, just modify the WHERE clause to not use comments. I don't even see the point of having comment titles. At present there is no way to edit a comment title so that will have to be added to the edit screen. I think editing a comment should be more inline with initially creating a comment. When you edit a comment you get access to the full wikiedit toolbar. You should also have the option of doing this with comments. Maybe make it like forums work by having a "Quick Comment" which is like we have now but then have a new button "Full Comment" which opens a screen like the current Edit Comment screen i.e. with the full toolbar. I'll try and do these changes today/tonight/tomorrow morning and get this section knocked off for good. I'm unresolving this issue. |
|
|
Properly fixed now in revision 701. 1) Comments are now sorted by their creation date. 2) Edited comments no longer have past revisions stored. 3) Comments title is now also editable. |
|
|
a) Preview mode for comment title does not work b) if edit_summary is set '2' in config body for comment and page gets lost |
|
|
dammit! |
|
|
Both fixed in revision 711. The second one was actually a much bigger problem in that non of the error messages were getting displayed and instead the broken page was getting saved. I'm not sure if this was because of my comment updates or if it was in there from when the summary note stuff was added. I think it's all fixed now. I had to format the code so I could see where the nesting was going wrong. |
|
|
Bug catched. :) |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-08-28 22:48 | EoNy | New Issue | |
| 2007-08-28 22:48 | EoNy | Note Added: 0000022 | |
| 2007-08-28 22:50 | EoNy | Additional Information Updated | |
| 2007-08-29 05:58 | administrator | Legacy | => NPJ |
| 2007-10-08 14:56 | administrator | Reporter | EoNy => administrator |
| 2007-10-08 14:56 | administrator | Additional Information Updated | |
| 2007-12-01 15:36 | Tann San | Status | new => assigned |
| 2007-12-01 15:36 | Tann San | Assigned To | => Tann San |
| 2008-04-04 01:25 | administrator | Relationship added | parent of 0000050 |
| 2009-10-10 20:27 | administrator | Target Version | => 5.4.0 |
| 2009-10-10 20:32 | administrator | Note Added: 0000686 | |
| 2009-10-10 20:34 | administrator | Relationship added | related to 0000252 |
| 2009-10-10 20:40 | administrator | Relationship added | related to 0000328 |
| 2009-10-13 11:08 | Tann San | Relationship deleted | parent of 0000050 |
| 2009-10-13 11:09 | Tann San | Relationship deleted | related to 0000252 |
| 2009-10-13 11:10 | Tann San | Note Added: 0000696 | |
| 2009-10-13 11:10 | Tann San | Status | assigned => resolved |
| 2009-10-13 11:10 | Tann San | Fixed in Version | => 4.3.rc |
| 2009-10-13 11:10 | Tann San | Resolution | open => fixed |
| 2009-10-13 11:11 | Tann San | Note Added: 0000697 | |
| 2009-10-13 13:59 | administrator | Note Added: 0000701 | |
| 2009-10-13 14:13 | Tann San | Note Added: 0000703 | |
| 2009-10-13 14:13 | Tann San | Status | resolved => assigned |
| 2009-10-14 12:36 | Tann San | Note Added: 0000708 | |
| 2009-10-14 12:36 | Tann San | Status | assigned => resolved |
| 2009-10-14 16:10 | administrator | Fixed in Version | 4.3.rc => 5.0.beta |
| 2009-10-15 04:37 | administrator | Note Added: 0000713 | |
| 2009-10-15 09:40 | Tann San | Note Added: 0000714 | |
| 2009-10-15 09:40 | Tann San | Status | resolved => acknowledged |
| 2009-10-15 10:53 | Tann San | Note Added: 0000715 | |
| 2009-10-15 10:53 | Tann San | Status | acknowledged => resolved |
| 2009-10-15 14:45 | administrator | Note Added: 0000716 | |
| 2010-01-21 22:16 | administrator | Target Version | 5.4.0 => 5.0.beta |
| 2010-02-22 18:22 | Freeman | Relationship added | child of 0000352 |
| 2010-03-08 10:12 | administrator | Category | Editing => editing |
| 2011-05-31 21:24 | administrator | Build | => R5.0.beta |
| 2011-05-31 21:51 | administrator | Fixed in Version | 5.0.beta => 5.0.rc |
| 2011-05-31 21:51 | administrator | Target Version | 5.0.beta => 5.0.rc |
| 2011-05-31 23:23 | administrator | Fixed in Version | 5.0.rc => 5.0.beta |
| 2011-05-31 23:23 | administrator | Target Version | 5.0.rc => 5.0.beta |
